Skip to content

Sub-second accuracy in syslog adapter#382

Open
romanlevin wants to merge 4 commits into
gliderlabs:masterfrom
romanlevin:subsecond-timestamps-syslog
Open

Sub-second accuracy in syslog adapter#382
romanlevin wants to merge 4 commits into
gliderlabs:masterfrom
romanlevin:subsecond-timestamps-syslog

Conversation

@romanlevin

Copy link
Copy Markdown

Other than unnecessarily losing timestamp accuracy, this breaks for syslog daemons that expect sub-second accuracy (like fluentd).

@josegonzalez josegonzalez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, do we need to have tests for this? Would it be better to somehow make this configurable?

@romanlevin

romanlevin commented Feb 19, 2018

Copy link
Copy Markdown
Author

Seems fine, do we need to have tests for this? Would it be better to somehow make this configurable?

@josegonzalez I'm new to contributing to logspout – are you asking me? I'm not super fluent in Go and the tests around the syslog adapter are a bit of the mystery to me at the moment.

Making this opt-in with an environment variable should be super simple even for me, but I'm not sure if that's what you meant by "configurable".

@jrd

jrd commented Dec 14, 2020

Copy link
Copy Markdown

Could this be merged and release, please?

@TomasLukl

Copy link
Copy Markdown

Could this be merged and release, please?

@progrium

progrium commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

Btw this LGTM ... let me know if repo needs to announce call for co-maintainers.

@josegonzalez

Copy link
Copy Markdown
Member

Yeah we should probably do that - I don't maintain the repo but Im sure there are folks that would want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No milisecond on timestamps causes log ordering issues

6 participants