WIP: Watch parties for YouTube#26
WIP: Watch parties for YouTube#26JerryBerry12 wants to merge 11 commits intoglaretechnologies:masterfrom
Conversation
…e before opening pr
…e before opening pr
Make sync actually work Make it so that when a client is in a watch party, they can't control the video Add Watch Party overlay so its clear we're in a watch party
Add "Watch party: synced" when you're in a watch party Reduce agrressiveness of correction to avoid jitter on lower-powered systems Make it so that non-hosts cannot control the video
…ll remove before opening pr" This reverts commit e32a337.
…ll remove before opening pr" This reverts commit d96584b.
|
Hi, synchronised video playback is definitely something I want, it has been requested a few times. I'll look at the code, thanks. |
|
no problem! |
|
Initial impressions are that this is way too much code for something that hopefully should be relatively simple. |
|
uh ok... 😅 I can try to pair it down, is there anything specific you see that's too much? |
|
Maybe you can start by describing what features this is adding. |
|
Well, the object owner can check a sync flag in ObjectEditor, which makes it so that when the video is loaded, there's a start watch party overlay button on the CEF window bottom left. the first person to load the video and click it becomes watch party host, they dictate timestamp and play/pause status to other clients. when other clients load the video and a watch party is status, they become slave to the host's timestamp and play/pause status control. |
| } | ||
|
|
||
| browser->executeJavaScript( | ||
| "if(!window.substrataSetWatchPartyButton){" |
There was a problem hiding this comment.
what is all this code for?
There was a problem hiding this comment.
for the start watch party button, it appears as an overlay in the browser window
|
if you'd rather me re-work this in a different way, just let me know and ill try my best |
2 participants
Hey Nick,
This adds a checkbox to video objects that can be checked if the video is on youtube, and then if the owner of the video checks it, the first person who loads the video can start a watch party, and then everyone who walks up to the video afterwards will be synced to the hosts controls and timestamps. I've only got it working with youtube so far, lmk if you want me to try to get it working with .mp4s first before merging, but other then that I think it looks pretty good. Lmk ur thoughts or if you even want this lol... Just made it for my world but thought I would share :)
Thanks,
Micah
(P.S. When you get a chance plz check your email, I sent you one about vehicles a couple days ago 🙂)