Repository navigation
fix: update upstream operation inventory tests in each patch that adds an operation - #60
Merged
Merged
Conversation
This was referenced Oct 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30.
The insert, clipboard and menu patches add 8 Bridge operations, which brings the full stack to 126. None of those patches updated upstream's operation inventory tests, so four tests in
PeekabooTestsfailed on main.Change
Each of the seven patches that adds an operation now updates the inventory tests within that same patch:
literalInsertclipboardTextRead,clipboardTextWriteclipboardImageReadclipboardFilesReadclipboardImageWritemenuCommandclipboardFilesWritePeekabooBridgeRequestPlanTestsandPeekabooBridgeOperationSemanticPlanTests.PeekabooBridgeRequestPlanTests.PeekabooBridgeOperationResultSemanticsTests.How the patches were regenerated:
peekaboo-clipboard-files-write.patchalso gets new hunk offsets and index hashes. It had been generated without the menu patch beneath it, and git apply was tolerating the offsets.The patches README now:
Core/PeekabooCorein the "builds without local edits" note;~/.peekaboolocks, foreground only, narrow filters with a hard limit, run in batches;Tests
npm run checknode dist/build.js), restoring the checkout from scratch.PeekabooBridgeRequestPlanTests,PeekabooBridgeOperationSemanticPlanTestsandPeekabooBridgeOperationResultSemanticsTests: 72 of 72 pass. On main these suites had 4 failures.PeekabooTestsBridge suites, in 3 foreground batches with a hard limit. The only remaining failures:PeekabooBridgeWindowEnumerationTimeoutTests,PeekabooBridgeSetValueFailureTests, and the remote targeted hotkey test inPeekabooBridgeTests.swift.#57 (dialog-path) sets its own count to 127 and adds itself to these lists. I'll rebase it after this merges.