Skip to content

fix: update upstream operation inventory tests in each patch that adds an operation - #60

Merged
iamnbutler merged 1 commit into
mainfrom
fix/operation-inventory-tests
Oct 17, 2026
Merged

iamnbutler merged 1 commit into
mainfrom
fix/operation-inventory-tests

Conversation

@iamnbutler

Copy link
Copy Markdown
Contributor

Fixes #30.

The insert, clipboard and menu patches add 8 Bridge operations, which brings the full stack to 126. None of those patches updated upstream's operation inventory tests, so four tests in PeekabooTests failed on main.

Change

Each of the seven patches that adds an operation now updates the inventory tests within that same patch:

Patch Operations Count Permission partition Mutating list
insert literalInsert 119 Accessibility + PostEvent yes
clipboard-text clipboardTextRead, clipboardTextWrite 121 none write only
clipboard-image clipboardImageRead 122 none no
clipboard-files clipboardFilesRead 123 none no
clipboard-image-write clipboardImageWrite 124 none yes
menu menuCommand 125 Accessibility yes
clipboard-files-write clipboardFilesWrite 126 none yes
  • "Count" is the wire count in PeekabooBridgeRequestPlanTests and PeekabooBridgeOperationSemanticPlanTests.
  • "Permission partition" is the set the operation joins in PeekabooBridgeRequestPlanTests.
  • "Mutating list" means the operation is added to the unconditionally mutating operations in PeekabooBridgeOperationResultSemanticsTests.

How the patches were regenerated:

  • Each patch was regenerated against its predecessor in stack order.
  • Each patch keeps its original diff style: index hash length, blank context lines, and no index lines or hunk headers for insert.
  • The rebuilt source tree differs from main's only in those three test files.
  • peekaboo-clipboard-files-write.patch also gets new hunk offsets and index hashes. It had been generated without the menu patch beneath it, and git apply was tolerating the offsets.

The patches README now:

Tests

  • npm run check
  • Native build of the full stack (node dist/build.js), restoring the checkout from scratch.
  • PeekabooBridgeRequestPlanTests, PeekabooBridgeOperationSemanticPlanTests and PeekabooBridgeOperationResultSemanticsTests: 72 of 72 pass. On main these suites had 4 failures.
  • All 95 PeekabooTests Bridge suites, in 3 foreground batches with a hard limit. The only remaining failures:

#57 (dialog-path) sets its own count to 127 and adds itself to these lists. I'll rebase it after this merges.

@iamnbutler
iamnbutler merged commit f912585 into main Oct 17, 2026
2 checks passed
@iamnbutler
iamnbutler deleted the fix/operation-inventory-tests branch October 17, 2026 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upstream operation-count tests fail with the patch stack (118 vs 126 operations)

1 participant