Repository navigation
fix(host): match a channel's pull request only among the repository's own branches - #641
Merged
Merged
Conversation
… own branches Why: apps/host/src/github.ts#function pull | gh --head matches a branch name in any fork; only same-repository pull requests are a channel's
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A channel's pull request now comes only from its own repository's branches.
gh pr list --head=<branch>matches the branch name in every fork, so a fresh clone of octocat/Hello-World onmastershowed a stranger's fork PR (#11598) with Update PR and Close PR. The host now lists up to 30 candidates and keeps the newest one that isn't cross-repository.Fixes #628. Map: ^715, ^692.
Smoke test on an isolated host (own ACE_HOME, port 4732,
--loopback):master) showsmasterand "No pull request" in Details, with no Update PR or Close PR. Before the fix,gh pr list --head=masterreturned the cross-repository #11598 first.Built in Ace
Made from Claude Code (a fix-train worker), not in Ace, because it was run headless as a parallel agent with its own isolated host. Gap tracked in the dogfooding meta issue, #5.