Skip to content

Comments

C++: Update expected test results after extractor changes#21208

Open
jketema wants to merge 1 commit intogithub:mainfrom
jketema:jketema/softfloat
Open

C++: Update expected test results after extractor changes#21208
jketema wants to merge 1 commit intogithub:mainfrom
jketema:jketema/softfloat

Conversation

@jketema
Copy link
Contributor

@jketema jketema commented Jan 22, 2026

No description provided.

@github-actions github-actions bot added the C++ label Jan 22, 2026
@jketema jketema added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Jan 22, 2026
@jketema jketema marked this pull request as ready for review February 17, 2026 13:34
@jketema jketema requested a review from a team as a code owner February 17, 2026 13:34
Copilot AI review requested due to automatic review settings February 17, 2026 13:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates expected test results in C++ query tests to reflect changes in how the extractor formats floating-point numbers. The extractor now uses scientific notation (e.g., 3.5E15) instead of full decimal representation (e.g., 3500000000000000.0) for large numbers, and shorter decimal representations (e.g., 2.71828) instead of high-precision formats (e.g., 2.71828000000000003) for regular floating-point values.

Changes:

  • Updated floating-point literal representations to use scientific notation for large values
  • Updated floating-point literal representations to use shorter decimal formats for regular values
  • Added sequential line numbers where they were previously missing in test expectations

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
cpp/ql/test/query-tests/Likely Bugs/Underspecified Functions/MistypedFunctionArguments.expected Updated floating-point literal formats and added missing line numbers for test expectations
cpp/ql/test/library-tests/rangeanalysis/SimpleRangeAnalysis/nrOfBounds.expected Updated floating-point literal formats to shorter decimal representations and added missing line numbers
cpp/ql/test/library-tests/controlflow/guards/GuardsEnsure.expected Updated floating-point literal format for small scientific notation value and added missing line numbers
cpp/ql/test/library-tests/controlflow/guards/GuardsCompare.expected Updated floating-point literal format for small scientific notation value and added missing line numbers
cpp/ql/test/library-tests/builtins/complex/builtin.expected Updated floating-point literal formats to shorter decimal representations and added missing line numbers

Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! (assuming tests pass on the corresponding branch)

@jketema
Copy link
Contributor Author

jketema commented Feb 20, 2026

assuming tests pass on the corresponding branch

They do.

Copy link
Contributor

@IdrissRio IdrissRio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants