Skip to content

Rust: Fix bad join #21057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvitved merged 1 commit into from
Dec 17, 2025
+15 −2
Merged

Rust: Fix bad join #21057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions rust/ql/lib/codeql/rust/frameworks/stdlib/Stdlib.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,19 @@ class IndexTrait extends Trait {
}
}

/**
* The [`IndexMut` trait][1].
*
* [1]: https://doc.rust-lang.org/std/ops/trait.IndexMut.html
*/
class IndexMutTrait extends Trait {
pragma[nomagic]
IndexMutTrait() { this.getCanonicalPath() = "core::ops::index::IndexMut" }

/** Gets the `index_mut` function. */
Function getIndexMutFunction() { result = this.(TraitItemNode).getAssocItem("index_mut") }
}

/**
* The [`Box` struct][1].
*
Expand Down
4 changes: 2 additions & 2 deletions rust/ql/lib/codeql/rust/internal/TypeInference.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1786,8 +1786,8 @@ private module MethodResolution {

override Trait getTrait() {
if this.isInMutableContext()
then result.getCanonicalPath() = "core::ops::index::IndexMut"
else result.getCanonicalPath() = "core::ops::index::Index"
then result instanceof IndexMutTrait
else result instanceof IndexTrait
}
}

Expand Down