Java: allow MaD barriers #21055
Draft
Java: allow MaD barriers #21055
+271
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was implemented by Gemini 3 using the following prompt. In the commit with the hash 10c5a47 the go language library was updated. I want you to do the same for the java language library. Here are the steps to follow: - Find all .ql files in the java folder which are not in java/ql/src/experimental which contain the string "@kind path-problem". - Note the query id, as specified by the "@id" metadata at the top of the .ql file. It should have this format: "java/sql-injection". - These are path queries, so the second and third arguments in the select statement should have type "XFlow::PathNode"s for some module "XFlow" that is defined as something like "TaintTracking::Global<XFlowConfig>". Find the definition of the data flow config ("XFlowConfig" in my example code), which should be a module which implements `DataFlow::ConfigSig`. - If the module does not already define it, add a predicate like the following: `predicate isBarrier(DataFlow::Node node) { barrierNode(node, "Z") }` where "Z" should be the query id from earlier. - If the module already defines that predicate, add `or barrierNode(node, "Z")` to the end of the predicate body, where "Z" should be the query id.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import semmle.code.java.dataflow.TaintTracking | ||
| import semmle.code.java.frameworks.android.Intent | ||
| import semmle.code.java.security.SensitiveActions | ||
| private import semmle.code.java.dataflow.ExternalFlow |
Check warning
Code scanning / CodeQL
Redundant import Warning
| /** Provides a taint-tracking configuration to reason about externally controlled format string vulnerabilities. */ | ||
|
|
||
| import java | ||
| private import semmle.code.java.dataflow.ExternalFlow |
Check warning
Code scanning / CodeQL
Redundant import Warning
| import semmle.code.java.dataflow.FlowSources | ||
| import semmle.code.java.dataflow.TaintTracking | ||
| import semmle.code.java.security.GroovyInjection | ||
| private import semmle.code.java.dataflow.ExternalFlow |
Check warning
Code scanning / CodeQL
Redundant import Warning
| import semmle.code.java.dataflow.TaintTracking | ||
| import semmle.code.java.dataflow.FlowSources | ||
| import semmle.code.java.security.SensitiveActions | ||
| private import semmle.code.java.dataflow.ExternalFlow |
Check warning
Code scanning / CodeQL
Redundant import Warning
| import semmle.code.java.dataflow.DataFlow | ||
| import semmle.code.java.controlflow.Guards | ||
| import semmle.code.java.security.SecurityTests | ||
| private import semmle.code.java.dataflow.ExternalFlow |
Check warning
Code scanning / CodeQL
Redundant import Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds classes so users can add query-specific sanitizers using data extensions ("models-as-data", or MaD), using the query id as the
kindstring to determine which queries it applies to. Note that in the PR where existing sanitizers were converted to MaD the extension points were all using existing sink kinds as thekindstring. I think it's fine for both to exist.To do: add more classes so that sanitizers can be added for more existing sink kinds and apply wherever the corresponding sinks would apply.
Note that the first commit was done using copilot (prompt in commit message).