test(repository): fixes linting errors#597
Merged
j-rewerts merged 1 commit intogithub-tools:masterfrom Jan 25, 2021
hazmah0:fix-lint-error
Merged
test(repository): fixes linting errors#597j-rewerts merged 1 commit intogithub-tools:masterfrom hazmah0:fix-lint-error
j-rewerts merged 1 commit intogithub-tools:masterfrom
hazmah0:fix-lint-error
Conversation
brandonbothell
approved these changes
Jan 5, 2020
brandonbothell
left a comment
brandonbothell
left a comment
There was a problem hiding this comment.
A failing test doesn't look too good and hinders PR compatibility checks.
|
@jasonhaxstuff not sure what you mean, mistakes happen. |
|
@DanielRuf I was stating a reason of approval. Pretend like I prefaced my comment with "I'm approving this because...". |
DanielRuf
approved these changes
Jan 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes that lint task is failing in CI since merging #588