Add WithFrom, WithAPIKey, WithBatchSize options#28
Merged
Conversation
Thread ecosyste.ms identity and batch-size knobs through to the underlying ecosystems-go client. Identifying the client (WithFrom or WithAPIKey) moves it out of the shared rate-limit pool, which the upstream issue at git-pkgs/git-pkgs#231 traced to opaque HTTP/2 stream rejections. WithBatchSize lets callers stay below stricter server-side limits. The options are ignored when running in direct registries mode, since the registries client has no equivalent knobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Threads ecosyste.ms identity and batch-size knobs through to the underlying
ecosystems-goclient.WithFrom(email)sets theFromheaderWithAPIKey(key)sets theAuthorization: BearerheaderWithBatchSize(size)caps bulk-lookup batch size below the upstream maxIdentifying the client moves it out of ecosyste.ms's shared rate-limit pool, which is the root cause traced in git-pkgs/git-pkgs#231 (opaque HTTP/2
INTERNAL_ERRORstream rejections).WithBatchSizelets callers stay below stricter server-side limits.The new options are no-ops when running in direct registries mode (
GIT_PKGS_DIRECT=1) since the registries client has no equivalent knobs.Pulls in
ecosystems-gov0.2.0 which adds the underlying options.