Skip to content

Conversation

@sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Dec 18, 2025

Description

Added new scope APIs: set_attribute and remove_attribute

  • Scopes now store their own attributes in _attributes
  • Attributes set on the scope are applied to logs and metrics

Also:

  • unify pre-serialization of attribute values a bit (format_attribute)

Resources:

Issues

Reminders

@linear
Copy link

linear bot commented Dec 18, 2025

@sentrivana sentrivana changed the title feat: Add scope.set_attribute feat(api): Add Scope.set_attribute Dec 18, 2025
Base automatically changed from ivana/make-logs-and-metrics-go-via-scope to master December 18, 2025 12:18
@sentrivana sentrivana marked this pull request as ready for review December 18, 2025 12:47
@sentrivana sentrivana requested a review from a team as a code owner December 18, 2025 12:47
Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely tested, looks good to me

@sentrivana sentrivana merged commit 244658e into master Dec 19, 2025
166 of 170 checks passed
@sentrivana sentrivana deleted the ivana/scope-set-attributes branch December 19, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement set_attributes API

3 participants