Skip to content

fix(ray): Guard against module shadowing #5254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexander-alderman-webb wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

fix(ray): Guard against module shadowing #5254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/ray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

try:
import ray # type: ignore[import-not-found]
from ray import remote
except ImportError:
raise DidNotEnable("Ray not installed.")

Expand All @@ -37,7 +38,7 @@ def _check_sentry_initialized() -> None:


def _patch_ray_remote() -> None:
old_remote = ray.remote
old_remote = remote

@functools.wraps(old_remote)
def new_remote(
Expand Down
1 change: 0 additions & 1 deletion tests/test_shadowed_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ def pytest_generate_tests(metafunc):
"litellm",
"opentelemetry",
"pure_eval",
"ray",
"trytond",
"typer",
},
Expand Down
Loading