ref: Reuse isObjectLike for object guards - #25058
Merged
Merged
Conversation
Co-Authored-By: OpenAI Codex <codex@openai.com>
Contributor
size-limit report 📦
|
msonnb
changed the title
isObjectLike for object guards
msonnb
marked this pull request as ready for review
October 5, 2026 14:42
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 42b71f5. Configure here.
| if (p === 'router' && typeof newValue === 'object' && newValue !== null) { | ||
| patchRouter(client, newValue, currentRouterPatchingNavigationSpanRef); | ||
| if (p === 'router' && isObjectLike(newValue)) { | ||
| patchRouter(client, newValue as unknown as NextRouter, currentRouterPatchingNavigationSpanRef); |
There was a problem hiding this comment.
Uncommented double cast on router
Low Severity
A new as unknown as NextRouter double-cast was added without a comment explaining why a safer typing is not possible. I flagged this because the review rules require every new double-cast in SDK source to include that justification.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 42b71f5. Configure here.
Member
Author
There was a problem hiding this comment.
was any before, we keep the assumption that Next assign a NextRouter here.
chargome
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse the existing
isObjectLikehelper for repeated non-null object guards across SDK packages. It checks the same runtime condition and narrows unknown values, allowing redundant type assertions to be removed without changing behavior.