feat: Allow passing state from tracked threads#7
Merged
Conversation
AbhiPrasad
approved these changes
Jun 10, 2025
|
|
||
| std::string state_str; | ||
| if (args.Length() == 1 && args[0]->IsValue()) { | ||
| MaybeLocal<String> maybe_json = v8::JSON::Stringify(context, args[0]); |
Contributor
There was a problem hiding this comment.
what if a return a huge json? Should we account for size limits in some way?
Collaborator
Author
There was a problem hiding this comment.
We need to think about this but I think the worse case is too much memory use or OOM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the existing ANR detection we need to collect some state from the threads. This is used to collect debug meta and the current session.
Rather than use
registerThread()to repeatedly poll from each thread,registerThread()is used to register the thread andthreadPoll()is used to poll.threadPoll()can optionally take a stateobjectwhich is stored with the thread information.v8::JSON::stringifyis used to serialise the state. Later when callingcaptureStackTrace(), for each thread theframeand anystateare returned.