feat(feedback): Add per-form shake detection and sample app showcases#5353
Merged
feat(feedback): Add per-form shake detection and sample app showcases#5353
Conversation
Resolve feedback options once in the constructor and reuse them in onCreate, avoiding duplicate resolution. Add per-form shake-to-show support via SentryShakeDetector that skips activation when the global FeedbackShakeIntegration is already enabled. Update sample app with custom form builder, auto-dismiss, programmatic capture, and shake-to-show examples. Co-Authored-By: Claude Opus 4.6 <[email protected]>
romtsn
force-pushed
the
rz/chore/feedback-samples-update
branch
from
6f64a4e to
f6f626b
Compare
romtsn
changed the title
Contributor
|
Co-Authored-By: Claude Opus 4.6 <[email protected]>
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8687935 | 294.00 ms | 304.02 ms | 10.02 ms |
| 6edfca2 | 305.52 ms | 432.78 ms | 127.26 ms |
| b6702b0 | 395.86 ms | 409.98 ms | 14.12 ms |
| a1eadfa | 345.67 ms | 411.26 ms | 65.59 ms |
| 889ecea | 367.58 ms | 437.52 ms | 69.94 ms |
| e2dce0b | 315.85 ms | 369.20 ms | 53.35 ms |
| d15471f | 322.58 ms | 396.08 ms | 73.50 ms |
| 62b579c | 349.26 ms | 426.26 ms | 77.00 ms |
| cf708bd | 434.73 ms | 502.96 ms | 68.22 ms |
| 6edfca2 | 316.43 ms | 398.90 ms | 82.46 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8687935 | 1.58 MiB | 2.19 MiB | 619.17 KiB |
| 6edfca2 | 1.58 MiB | 2.13 MiB | 559.07 KiB |
| b6702b0 | 1.58 MiB | 2.12 MiB | 551.79 KiB |
| a1eadfa | 0 B | 0 B | 0 B |
| 889ecea | 1.58 MiB | 2.11 MiB | 539.75 KiB |
| e2dce0b | 0 B | 0 B | 0 B |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| 62b579c | 0 B | 0 B | 0 B |
| cf708bd | 1.58 MiB | 2.11 MiB | 539.71 KiB |
| 6edfca2 | 1.58 MiB | 2.13 MiB | 559.07 KiB |
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 929b476. Configure here.
antonis
approved these changes
May 4, 2026
Contributor
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
LGTM!
Also tested on a Pixel 8 Pro with Android 16 and the shake detection worked as expected 🚀
Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add per-instance shake-to-show support on
SentryUserFeedbackFormand update the sample app with examples covering the new feedback API surface.Per-form shake detection
SentryUserFeedbackFormnow supports per-instance shake-to-show via the options configurator (isUseShakeGesture = true). When the globalFeedbackShakeIntegrationis already active, per-form shake is skipped to avoid conflicts. Feedback options are resolved once in the constructor and reused inonCreate.Sample app showcases
Updated
UserFeedbackScreenwith examples for: custom form via Builder with many options, auto-dismiss form, programmaticFeedbackcapture without a form, and shake-to-show toggle.Closes #5305