Skip to content

fix(replay): text layouts with center/end alignment return incorrect masking bounding box #5218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markushi merged 9 commits into from
Mar 25, 2026
+460 −73
Merged

fix(replay): text layouts with center/end alignment return incorrect masking bounding box #5218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cfdcadc
Remove fill workaround, shortcut calculations if there's only one lin…
markushi Mar 20, 2026
781043a
changelog
markushi Mar 20, 2026
1daf0c5
Revert "Remove fill workaround, shortcut calculations if there's only…
markushi Mar 20, 2026
0492557
Work around erroneous paragraph return values
markushi Mar 20, 2026
8cd317c
Cover some more edge cases
markushi Mar 23, 2026
eee1c1d
Format code
getsentry-bot Mar 23, 2026
b2e95db
Trigger Build
markushi Mar 24, 2026
2e7b083
fix dependencies
markushi Mar 24, 2026
5ddd387
Add snapshot tests for non-ellipsized multi-line text masking
markushi Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Fixes

- Session Replay: Fix Compose text masking mismatch with weighted text ([#5218](https://github.com/getsentry/sentry-java/pull/5218))

### Features

- Android: Add `beforeErrorSampling` callback to Session Replay ([#5214](https://github.com/getsentry/sentry-java/pull/5214))
Expand Down
7 changes: 6 additions & 1 deletion sentry-android-core/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import org.jetbrains.kotlin.config.KotlinCompilerVersion
plugins {
id("com.android.library")
alias(libs.plugins.kotlin.android)
alias(libs.plugins.kotlin.compose)
jacoco
alias(libs.plugins.jacoco.android)
alias(libs.plugins.errorprone)
Expand Down Expand Up @@ -108,7 +109,11 @@ dependencies {
testImplementation(projects.sentryCompose)
testImplementation(projects.sentryAndroidNdk)
testImplementation(libs.dropbox.differ)
testRuntimeOnly(libs.androidx.compose.ui)
testImplementation(libs.androidx.activity.compose)
testImplementation(libs.androidx.compose.ui)
testImplementation(libs.androidx.compose.foundation)
testImplementation(libs.androidx.compose.foundation.layout)
testImplementation(libs.androidx.compose.material3)
testRuntimeOnly(libs.androidx.fragment.ktx)
testRuntimeOnly(libs.timber)
}
Loading
Loading