Skip to content

chore(gocd): use GitHub App credentials #6327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joshuarli wants to merge 3 commits into
base: master
Choose a base branch
from
+7 −5
Draft

chore(gocd): use GitHub App credentials #6327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
953e4ab
chore(gocd): use GitHub App credentials
joshuarli Aug 26, 2026
d3caa88
use checkruns2 for GitHub App credentials
joshuarli Aug 27, 2026
4b7e8ea
clarify checkruns2 App credential usage
joshuarli Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions gocd/pipelines/relay-experimental.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,14 @@ pipelines:
jobs:
checks:
environment_variables:
# Required for checkruns.
GITHUB_TOKEN: "{{SECRET:[devinfra-github][token]}}"
# Required for checkruns2.
GITHUB_APP_ID: "{{SECRET:[devinfra-github][app_id]}}"
GITHUB_APP_PRIVATE_KEY: "{{SECRET:[devinfra-github][private_key]}}"
timeout: 1800
elastic_profile_id: relay
tasks:
- script: |
checks-githubactions-checkruns \
checks-githubactions-checkruns2 \
getsentry/relay \
${GO_REVISION_RELAY_REPO} \
"Integration Tests" \
Expand Down
2 changes: 1 addition & 1 deletion gocd/templates/bash/github-check-runs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/bash

checks-githubactions-checkruns \
checks-githubactions-checkruns2 \
getsentry/relay \
"${GO_REVISION_RELAY_REPO}" \
"Integration Tests" \
Expand Down
3 changes: 2 additions & 1 deletion gocd/templates/libs/utils.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ local gocdtasks = import 'github.com/getsentry/gocd-jsonnet/libs/gocd-tasks.libs
jobs: {
checks: {
environment_variables: {
GITHUB_TOKEN: '{{SECRET:[devinfra-github][token]}}',
GITHUB_APP_ID: '{{SECRET:[devinfra-github][app_id]}}',
GITHUB_APP_PRIVATE_KEY: '{{SECRET:[devinfra-github][private_key]}}',
},
timeout: 1800,
elastic_profile_id: 'relay',
Expand Down
Loading