Skip to content

ref: brew-managed uv, requirements -> uv.lock, pin 3.14.4-slim-bookworm#631

Merged
joshuarli merged 8 commits into
mainfrom
kjiang/remove_managed_uv
Jun 4, 2026
Merged

ref: brew-managed uv, requirements -> uv.lock, pin 3.14.4-slim-bookworm#631
joshuarli merged 8 commits into
mainfrom
kjiang/remove_managed_uv

Conversation

@kenzoengineer

Copy link
Copy Markdown
Member

like here, we shouldn't manage UV anymore with devenv: https://github.com/getsentry/sentry-options-automator/pull/7343

@kenzoengineer kenzoengineer requested a review from joshuarli June 4, 2026 21:00
Comment thread devenv/config.ini Outdated
Comment thread devenv/sync.py Outdated

@joshuarli joshuarli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to also add brew 'uv' to Brewfile and add

    if constants.DARWIN:
        brew.install()

        proc.run(
            (f"{constants.homebrew_bin}/brew", "bundle"),
            cwd=reporoot,
        )

@kenzoengineer kenzoengineer requested a review from joshuarli June 4, 2026 21:07
Comment thread devenv/sync.py
Comment thread devenv/sync.py
Comment thread devenv/sync.py
Comment thread devenv/sync.py
Comment thread devenv/sync.py
Comment thread devenv/sync.py
@joshuarli joshuarli changed the title chore(devenv): Remove references to manged UV ref: brew-managed uv, requirements -> uv.lock Jun 4, 2026
Comment thread Dockerfile
Comment thread tests/e2e/mock-sentry-api/Dockerfile
@joshuarli joshuarli changed the title ref: brew-managed uv, requirements -> uv.lock ref: brew-managed uv, requirements -> uv.lock, pin 3.14.4-slim-bookworm Jun 4, 2026
Comment thread devenv/sync.py
Comment thread tests/e2e/mock-sentry-api/Dockerfile

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 764817e. Configure here.

Comment thread Makefile
Comment thread devenv/sync.py
Comment thread .github/workflows/ci.yml
@joshuarli joshuarli merged commit 8d57061 into main Jun 4, 2026
22 of 23 checks passed
@joshuarli joshuarli deleted the kjiang/remove_managed_uv branch June 4, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants