Chore(optimisation): rewrite BillableMetricFilters::RefreshDraftInvocies query to get rid of the joins - #6071
Draft
annvelents wants to merge 1 commit into
Draft
Chore(optimisation): rewrite BillableMetricFilters::RefreshDraftInvocies query to get rid of the joins#6071annvelents wants to merge 1 commit into
annvelents wants to merge 1 commit into
Conversation
jdenquin
reviewed
Aug 4, 2026
| .distinct | ||
| .in_batches do |batch| | ||
| .where(id: InvoiceSubscription | ||
| .where(subscription_id: Subscription.where(plan_id: plan_ids).select(:id)) |
Contributor
There was a problem hiding this comment.
should we filter on active sub only?
Contributor
Author
There was a problem hiding this comment.
actually, no
because if subscription is terminating / upgrading, we can generate an invoice that will be draft, when the subscription is already terminated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The job of refreshing invoices fails with timeout, having a separate query + subquery will help us not to join all the tables together