Chore(subscription-termination): change termination behaviour to hourly - #6004
Open
annvelents wants to merge 3 commits into
Open
Chore(subscription-termination): change termination behaviour to hourly#6004annvelents wants to merge 3 commits into
annvelents wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Before we were comparing date of ending_at to date of today, resulting in subscirptions terminating sometimes long before their actual termination date
Now we'll be terminating each hour subscriptions that ended during this hour
Description
Changed TerminateEndedSubscriptionsJob to check which subscriptions need to be terminated by checking which of them are in the past
Edge cases:
Billing is at 00:10
termination is at 23:59
after billing, before subscription there is usage
make sure no usage is lost
billing is at 00:10
termination is at 00:10
make sure there are no double-billing
Termination is at 00:01
Billing is at 00:10
no double invoices