Repository navigation
ci: Add multi-arch docker build with dual-registry push - #1139
johnnyasantoss wants to merge 1 commit into
Conversation
|
You can also test with |
a304574 to
b6c1440
Compare
|
Rebased. Prev ci failure was not related to this branch |
|
I've ran the clippy command locally and it's working. CI doesn't seem to be working or related to this. |
|
@johnnyasantoss can you rebase? The clippy error should be fixed now. |
b6c1440 to
50928ef
Compare
|
Rebased |
|
needs rebase |
50928ef to
49f4ee8
Compare
Done. Rebased. |
|
@johnnyasantoss can you also add the readme to the container metadata? |
49f4ee8 to
fb905e3
Compare
yes and no. I wish it was so simple. See: I pushed a change linking to this repo's readme (which is the one I believe you are referring to) |
|
I can add something like this if you want: https://github.com/peter-evans/dockerhub-description |
fb905e3 to
1301bbf
Compare
|
Rebased |
fb2b191 to
9d51fcf
Compare
|
Vibe-review for the changes, feel free to dismiss what's not relevant
My comment was about the text shown here, currently it says |
|
I have validated the image pull on a ARM64 and it is working. @johnnyasantoss can you please check Davidson's findings? Tks! @Davidson-Souza maybe, initially, we can publish the images only on GitHub. It was nice to see them published there, like in Johnny's fork https://github.com/johnnyasantoss/floresta/pkgs/container/floresta |
I have no problem on using ghcr-only for now. The priority here is the multi-arch setup since that will be useful for |
|
Ok. That |
9d51fcf to
5f48704
Compare
All addressed. Sorry for the delay. I don't think 2 & 3 were ever going to happen but it's fixed anyway.
Yes, that's what that tool does. DockerHub does NOT auto generate that based on readme or any other file. It has its own way of creating the overview. Rebased too. |
Adds a matrix build for linux/amd64, linux/arm64, and linux/arm/v7 (most common linux server archs) to the Docker workflow. Per-arch images are pushed to both GHCR and DockerHub, then merged into multi-arch manifests with proper version and branch tags. Supports manual workflow_dispatch to rebuild and publish images for previous tags. The merge logic is externalized into shell scripts under .github/workflows/docker/ for maintainability. The manifest creation uses a self-contained 5-step process (merge to GHCR, copy to Docker Hub, cleanup temp tags, copy back, tag versions) to avoid dangling references from deleted per-arch temp tags. A catch-all cleanup step runs regardless of success/failure. Also adds OCI labels to the Dockerfile following best practices. Assisted-by: GLM 5.2
b128729 to
342efb8
Compare
|
@csgui sorry for force pushing after your ack Just fixed the ref to the temp tags that's used in the last step of the action. Running perfectly now: |
Description and Notes
Adds a matrix build for linux/amd64, linux/arm64, and linux/arm/v7 (most common
linux server archs) to the Docker workflow.
Per-arch images are pushed to both GHCR and DockerHub, then merged into multi-arch manifests with proper
version and branch tags. Supports manual workflow_dispatch to rebuild and
publish images for previous tags.
The merge logic is externalized into shell scripts under .github/workflows/docker/ for maintainability. The manifest creation uses
a self-contained 5-step process (merge to GHCR, copy to Docker Hub, cleanup
temp tags, copy back, tag versions) to avoid dangling references from deleted
per-arch temp tags. A catch-all cleanup step runs regardless of success/failure.
Also adds OCI labels to the Dockerfile following best practices.
Related to #588
How to verify the changes you have done?
See my fork. https://github.com/johnnyasantoss/floresta/actions/runs/27847196957
Contributor Checklist
just pcc(recommended but slower)just lint-features '-- -D warnings' && cargo test --releaseFinally, you are encouraged to sign all your commits (it proves authorship and guards against tampering—see How (and why) to sign Git commits and GitHub's guide to signing commits).