Configurable menubar status period#302
Open
ozymandiashh wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Validation run on macOS arm64 with real local usage data. No project names, prompts, paths, session IDs, or internal product details are included here. Commands run:
Results:
Swift unit tests were not used for this validation because the current local Swift test target is blocked by the pre-existing |
426a71c to
1f9b444
Compare
Contributor
Author
|
Visual validation for #302 after the latest rebase.
Screenshot reviewed and approved by the contributor before posting.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Rebases the configurable menubar status period feature onto current
main.The always-visible macOS status item can now track Today, Week, Month, or 6 Months independently from the popover's selected period/provider filters.
Closes #291.
What changed
CodeBurnMenubarPeriodsetting backed byUserDefaults.menubarPeriod/menubarPayloadinstead of always using today's payload.mainrefresh hardening while refreshing the configured status period and the Today payload when the popover still needs day-specific data.menubarPeriodprivate(set)so callers must go throughsetMenubarPeriod, which validates allowed status periods and refreshes quietly./wk,/mo, and/6moin compact mode.Validation
npx vitest run- 60 files / 860 tests passed.npm run build- passed.swift build- passed.git diff --check- passed.Notes
swift test --filter MenubarPeriodSettingsTestsis still blocked locally by existing Swift test files that importTesting(no such module 'Testing'). The newMenubarPeriodSettingsTestsfile now uses XCTest and is no longer the source of that blocker.