Skip to content

'AnyDataModel' is declared but never used. when schema validation is enabled. #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DesertIce wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −1
Open

'AnyDataModel' is declared but never used. when schema validation is enabled. #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/cli/codegen_templates/dataModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,20 @@ async function staticDataModelImpl(
return useTypeScript ? noSchemaDataModelTS() : noSchemaDataModelDTS();
}

// Conditionally include AnyDataModel in the import only when schema
// validation is disabled (it is used later as `& AnyDataModel`).
const serverImports = [
"DocumentByName",
"TableNamesInDataModel",
"SystemTableNames",
];
if (!analysis.schema.schemaValidation) {
serverImports.push("AnyDataModel");
}

const lines = [
header("Generated data model types."),
`import type { DocumentByName, TableNamesInDataModel, SystemTableNames, AnyDataModel } from "convex/server";`,
`import type { ${serverImports.join(", ")} } from "convex/server";`,
`import type { GenericId } from "convex/values";`,
];
for await (const line of codegenDataModel(ctx, analysis.schema)) {
Expand Down