fix(workflow): update ISO workflow regarding uploads#41
Draft
inffy wants to merge 1 commit intoget-aurora-dev:mainfrom
Draft
fix(workflow): update ISO workflow regarding uploads#41inffy wants to merge 1 commit intoget-aurora-dev:mainfrom
inffy wants to merge 1 commit intoget-aurora-dev:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the ISO build workflows so PR runs upload build outputs as GitHub job artifacts, while merge queue (merge_group) runs upload the ISO outputs to the Cloudflare R2 testing bucket without producing job artifacts.
Changes:
- Switch artifact uploading in the reusable workflow to be controlled by
inputs.upload_artifacts(instead of event-name checks). - Switch R2 upload steps in the reusable workflow to be controlled by
inputs.upload_r2. - Update the stable ISO caller workflow to set
upload_artifactsfor PR checks and setupload_r2for merge queue + schedule + manual dispatch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/reusable-build-iso-anaconda.yml | Gates artifact and R2 upload steps solely via reusable-workflow inputs. |
| .github/workflows/build-iso-stable.yml | Sets reusable-workflow inputs based on pull_request, merge_group, schedule, and workflow_dispatch triggers to match the desired upload behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small changes to uploads
Other things are kept, like the manual workflow dispatch etc