Clearer System Requirements in DESCRIPTION and error messages on build time#82
Merged
Conversation
eddelbuettel
approved these changes
Feb 22, 2026
eddelbuettel
left a comment
eddelbuettel
left a comment
There was a problem hiding this comment.
That looks good to me from a glance, but untested. (I have written a few of these myself, and it can be finicky.)
Adding GNU make to SystemRequirements: covers you there.
Related: I was glancing at Arrow changes today as they have a new 23.0.1 and I spotted that they differenciate between clang and apple clang for their C++20 needs. You could add that. From what I saw at your CRAN results page you may have work to do for macOS on arm64 (or twist the arm of @s-u to get you a newer compiler, no idea if one is available).
Collaborator
Author
|
Thanks! Guess I am off to the mac issue now |
schochastics
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #81
@eddelbuettel does this suffice?