Skip to content

[ENH] Add comprehensive input validation with custom exception handling#68

Merged
Leguark merged 2 commits intomainfrom
check_input
Apr 24, 2026
Merged

[ENH] Add comprehensive input validation with custom exception handling#68
Leguark merged 2 commits intomainfrom
check_input

Conversation

@Leguark
Copy link
Copy Markdown
Member

@Leguark Leguark commented Apr 7, 2026

Input Validation Enhancement

  • Added GemPyEngineInputError exception class for handling input validation errors across the engine
  • Implemented comprehensive input validation in _check_input_validity function to verify consistency between InterpolationInput, TensorsStructure, and StacksStructure
  • Added validation checks for orientation data consistency, surface point counts, stack requirements, and cross-structure alignment
  • Disabled automatic filtering of zero values in TensorsStructure and StacksStructure to enable proper validation of empty stacks and surfaces
  • Created comprehensive test suite covering validation scenarios including mismatched counts, empty stacks/surfaces, and internal data inconsistencies
  • Added .junie to gitignore for test artifacts

…ompute_model`

- Added `GemPyEngineInputError` for handling input validation errors across the engine.
- Implemented `_check_input_validity` to ensure consistency between `InterpolationInput`, `InterpolationOptions`, and `InputDataDescriptor`.
- Introduced unit tests to validate scenarios such as mismatched surface points, stacks without points or orientations, and internal orientation inconsistencies.
- Updated logic in `tensors_structure` and `stacks_structure` to allow zero counts for more precise validation.
@Leguark Leguark marked this pull request as ready for review April 7, 2026 11:08
Copy link
Copy Markdown
Member Author

Leguark commented Apr 7, 2026

@Leguark Leguark changed the title [ENH] Add input validation framework and integrate basic tests for compute_model [ENH] Add comprehensive input validation with custom exception handling Apr 7, 2026
Copy link
Copy Markdown
Member Author

Leguark commented Apr 24, 2026

Merge activity

  • Apr 24, 1:00 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 24, 1:00 PM UTC: @Leguark merged this pull request with Graphite.

@Leguark Leguark merged commit 6d72e12 into main Apr 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant