Follow-up: Set PG UUID PKs for non-duplicate features on UPDATE mode#43
Merged
Conversation
… target layer's PK on update mode (i.e., duplicate features' PKs remain untouched, but non-duplicate features are appended bringing their PK from the source, despite the target layer's PK being automatic)
…non-duplicated (i.e., appended) target features
…he PK for non-duplicated (i.e., appended) target features
…o be set for non-duplicate features from the source layer (without updating the existing PK value for duplicate features)!
…h existing UUIDs, BUT we do set the PK from source for non-duplicate features being appended on UPDATE mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complex subject :), let's summarize how do we handle PKs:
(e.g., serial)
Non-duplicate features: Let's the provider fill the value automatically, except for UUID PKs on PostgreSQL, where the value is set from the source layer (if given)!
Non-duplicate features: The value is set from the source layer (it should always be given)!
New tests and test enhancements included.
Ref #42