Open
Conversation
Enables use of Tab(role: .search) and other iOS 18+ tab features within the FuturedArchitecture coordinator pattern. Extracts shared modal presentation logic into ModalCoverModifier to reduce duplication.
janpollak
requested review from
jmarek41,
matejsemancik and
ssestak
and removed request for
matejsemancik
ssestak
reviewed
Mar 23, 2026
| // MARK: - Shared Modal Presentation | ||
|
|
||
| /// Shared modifier that adds sheet and full-screen cover presentation to any coordinator-backed view. | ||
| struct ModalCoverModifier<C: Coordinator>: ViewModifier { |
Contributor
There was a problem hiding this comment.
Toto by som uz ked tak vyextrahoval a prepouzil aj v ostatnych FlowCoordinatorch, ktore maju modal support.
ssestak
reviewed
Mar 23, 2026
Comment on lines
+46
to
+47
| @available(iOS 18.0, macOS 15.0, tvOS 18.0, watchOS 11.0, *) | ||
| public struct TabContentFlow<Coordinator: TabCoordinator, Content: TabContent<Coordinator.Tab>>: View { |
Contributor
There was a problem hiding this comment.
Zaroven by som pridal deprecation flag na tú pôvodnú štruktúru TabViewFlow
NSItemProvider (non-Sendable) was being sent across isolation boundaries when calling the async loadImage() method. Fix uses actor confinement: Task runs on @mainactor, and loadImageData() extracts Data (Sendable) from the provider while staying on the same actor. UIImage is then created from the data.
janpollak
force-pushed
the
feature/tab-content-flow
branch
from
e3d9ba9 to
65e3aa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TabContentFlow— variantaTabViewFlowpro iOS 18+TabAPI (@TabContentBuilder)Tab(role: .search)a dalších iOS 18+ tab features v coordinator patternuModalCoverModifier(snížení duplikace)TabViewFlowzůstává pro zpětnou kompatibilitu