Skip to content

fix: MP-44653 remaining issues (combined fresh PR)#54

Open
annamalai-shan wants to merge 1 commit into
mainfrom
fix/mp-44653-combined
Open

fix: MP-44653 remaining issues (combined fresh PR)#54
annamalai-shan wants to merge 1 commit into
mainfrom
fix/mp-44653-combined

Conversation

@annamalai-shan

Copy link
Copy Markdown
Collaborator

Summary

Single fresh commit from main combining all remaining MP-44653 follow-ups. Supersedes these branches (do not merge separately):

Issue Change
#29 copySkills() copies only fw-* skill dirs, not skills/shared/
#31 Fix Best Practices #4 in oauth-configuration-latest.md
#32 Fix stale auth_type checklist in fdk_create.md
#39 Eval layer policy table + eval-manual.yml workflow_dispatch
#43 SECURITY.md telemetry disclosure for publish zip
#45 fw-setup dual-stack nvm rules + broadened CDN registry warnings
PR #53 meta-init.sh auto-detect IDE client; skills use single-arg init

Closes #29, #31, #32, #39, #43, #45.

Test plan

  • cd installer && npm test — 131 passed
  • cd tests && npm test — 355 passed (1 skipped pre-existing)
  • rg 'auth_type\|oauth_provider' skills/fw-app-dev/references/cli/fdk_create.md — zero matches
  • LLM evals (cd tests && npm run eval) — run locally and attach tests/all-tests-report.html if required by reviewers

…l policy, meta-init

Closes #29, #31, #32, #39, #43, #45. Supersedes branches fix/mp-44653-oauth-fw-setup,
fix/mp-44653-eval-policy, feat/installer-fixes-and-security-docs, feat/auto-detect-ide-client,
and PR #53.
@github-actions

Copy link
Copy Markdown

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 3 package(s) with unknown licenses.
See the Details below.

License Issues

.github/workflows/eval-manual.yml

PackageVersionLicenseIssue Type
actions/checkout4.*.*NullUnknown License
actions/setup-node4.*.*NullUnknown License
actions/upload-artifact4.*.*NullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
actions/actions/checkout 4.*.* 🟢 6.9
Details
CheckScoreReason
Maintained🟢 1024 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 10
Code-Review🟢 10all changesets reviewed
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Binary-Artifacts🟢 10no binaries found in the repo
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Fuzzing⚠️ 0project is not fuzzed
Packaging⚠️ -1packaging workflow not detected
Pinned-Dependencies🟢 3dependency not pinned by hash detected -- score normalized to 3
Signed-Releases⚠️ -1no releases found
Security-Policy🟢 9security policy file detected
SAST🟢 10SAST tool is run on all commits
Branch-Protection🟢 5branch protection is not maximal on development and all release branches
actions/actions/setup-node 4.*.* 🟢 6.3
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Maintained🟢 1017 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 10
Packaging⚠️ -1packaging workflow not detected
Binary-Artifacts🟢 9binaries present in source code
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Pinned-Dependencies🟢 5dependency not pinned by hash detected -- score normalized to 5
License🟢 10license file detected
Fuzzing⚠️ 0project is not fuzzed
Signed-Releases⚠️ -1no releases found
Security-Policy🟢 9security policy file detected
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
SAST🟢 9SAST tool is not run on all commits -- score normalized to 9
actions/actions/upload-artifact 4.*.* 🟢 5.2
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
Maintained⚠️ 00 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 0
Binary-Artifacts🟢 10no binaries found in the repo
Packaging⚠️ -1packaging workflow not detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Pinned-Dependencies⚠️ 1dependency not pinned by hash detected -- score normalized to 1
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Security-Policy🟢 9security policy file detected
SAST🟢 10SAST tool is run on all commits
Branch-Protection⚠️ 0branch protection not enabled on development/release branches

Scanned Files

  • .github/workflows/eval-manual.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

copySkills() copies skills/shared into IDE skills directory

1 participant