fix: log update check failures via console.warn instead of silent swallow#3854
Open
SisyphusZheng wants to merge 2 commits into
Open
fix: log update check failures via console.warn instead of silent swallow#3854SisyphusZheng wants to merge 2 commits into
SisyphusZheng wants to merge 2 commits into
Conversation
The update check in both the esbuild builder and Vite plugin used \.catch(() => {})\ which silently discards all errors. This means network failures, parse errors, and timeouts during version checking are never surfaced to the developer.
Log failures via \console.debug\ so they appear in verbose/debug output without cluttering normal dev server output.
\console.debug\ output is invisible at Deno's default log level (\info\), making the fix functionally equivalent to the original silent swallow. \console.warn\ ensures the failure is visible in normal dev server output without needing \--log-level debug\.
SisyphusZheng
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update check in both the esbuild builder (\packages/fresh/src/dev/builder.ts) and Vite plugin (\packages/plugin-vite/src/mod.ts) used .catch(() => {})\ which silently discards all errors.
Network failures, parse errors, and timeouts during version checking were never surfaced to the developer, even in verbose/debug mode.
This PR logs failures via \console.debug\ so they appear in debug output without cluttering normal dev server logs.