fix(tasks): persist status & priority from the desktop sidebar#497
Open
Profit-Rocket wants to merge 1 commit into
Open
fix(tasks): persist status & priority from the desktop sidebar#497Profit-Rocket wants to merge 1 commit into
Profit-Rocket wants to merge 1 commit into
Conversation
The desktop task sidebar rendered Status/Priority as <Select v-model> whose options carry onClick: task.setValue.submit(...). A native <Select> never fires per-option onClick (that's a Dropdown pattern), and there was no @update:modelValue handler, so selecting a value only mutated the local doc and never persisted — no autosave, reverts on reload. The mobile <Dropdown> layout was unaffected. Switch both to :modelValue + @update:modelValue -> task.setValue.submit(), matching the sibling Assignee/Space/Due Date controls.
Contributor
UI Test Results❌ 4 failed — 31/35 tests passed in 2m 2s.
Results for commit d066b0f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a task detail page (desktop,
sm:blocksidebar), selecting a Status or Priority appears to change but never persists — no autosave, reverts on reload. Comments and the other sidebar fields (Assignee/Space/Due Date) save fine. The mobile layout (<Dropdown>) is unaffected.Cause
TaskDetail.vuedesktop sidebar uses:where
statusOptionsentries carryonClick: () => task.setValue.submit({ status }). A native<Select>renders<option>elements and never invokes per-optiononClick(that's a<Dropdown>pattern); with onlyv-modelthe change mutates the local doc and never callssetValue. Priority has the same issue.Fix
Switch both to
:modelValue+@update:modelValue → task.setValue.submit(), mirroring the working Assignee/Space/Due Date controls in the same component.