Shashwat/storage migration#1695
Conversation
|
@animator Please review this PR. |
ShashwatXD
force-pushed
the
shashwat/storageMigration
branch
from
da9377a to
6916394
Compare
| final requestDirPath = _path(_requestDirRelative(collectionId, id)); | ||
| merged['httpResponseModel'] = | ||
| _inlineResponseBodyFile(requestDirPath, responseJson); |
There was a problem hiding this comment.
are we doing any validations on the filenames if they're coming from the responseJson directly?
if these workspaces can be imported and shared via git and what not then certain relative paths and stuff might be able to cause unintended effects.
lmk if this is handled
| fvp: ^0.35.2 | ||
| highlight: ^0.7.0 | ||
| highlighter: ^0.1.1 | ||
| hive_ce_flutter: ^2.3.4 |
There was a problem hiding this comment.
minor: pubspec.lock still contains
hive_ce_flutter:
dependency: "direct main"
description:
name: hive_ce_flutter
sha256: "2677e95a333ff15af43ccd06af7eb7abbf1a4f154ea071997f3de4346cae913a"
url: "https://pub.dev"
source: hosted
version: "2.3.4"
maybe you missed doing pub get and then adding lockfile also to changes?
| if (kIsDesktop) | ||
| const Expanded( | ||
| child: WorkspaceDropdown(), | ||
| ), | ||
| if (kIsDesktop) kHSpacer4, |
There was a problem hiding this comment.
nitpick: could be put in a spread ... [...] i guess
| Future<String?> resolveWorkspaceRoot({ | ||
| required bool useDesktopPath, | ||
| String? desktopPath, | ||
| }) async { | ||
| if (useDesktopPath) { | ||
| if (desktopPath == null || desktopPath.isEmpty) { | ||
| return null; | ||
| } | ||
| return desktopPath; | ||
| } |
There was a problem hiding this comment.
why do we have useDesktopPaht and desktopPath both?
like if desktopPath is non-null cant we assume that we must use it?
| static bool _shouldShowEnvironmentMenu(String environmentId) { | ||
| return environmentId != kGlobalEnvironmentId; | ||
| } |
There was a problem hiding this comment.
nitpick: could have been inlined, no need for separate function
2 participants
Storage migration to file system.
Added
collections/,environments/,history/as JSON)Removed
hive_services)