Skip to content

Early AD - True Positive list fetching - #655

Open
RCantu92 wants to merge 21 commits into
mainfrom
feat/ad-tp-list
Open

RCantu92 wants to merge 21 commits into
mainfrom
feat/ad-tp-list

Conversation

@RCantu92

@RCantu92 RCantu92 commented Jun 3, 2024

Copy link
Copy Markdown
Contributor

Adding logic for the Early Attack Detector to be able to query for True Positive that have been identified

25 June edit: Changes deployed to Early Attack Detector Beta, but not merged to main because not deployed to PROD Early Attack Detector.

@RCantu92 RCantu92 self-assigned this Jun 4, 2024
@RCantu92
RCantu92 marked this pull request as ready for review June 4, 2024 22:15
@Vxatz
Vxatz requested review from Vxatz and salort-forta June 5, 2024 08:27
Comment thread early-attack-detector-py/src/utils.py Outdated
Comment thread early-attack-detector-py/src/utils.py Outdated
Comment thread early-attack-detector-py/src/agent.py Outdated
Comment thread early-attack-detector-py/src/agent.py Outdated
Comment thread early-attack-detector-py/src/constants.py Outdated
@RCantu92
RCantu92 requested a review from Vxatz June 11, 2024 22:53

@Vxatz Vxatz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a few changes, the only crucial is the one in the handle_alert

Comment thread early-attack-detector-py/src/utils.py Outdated
Comment thread early-attack-detector-py/src/agent.py Outdated
Comment thread early-attack-detector-py/src/agent.py Outdated
Comment thread early-attack-detector-py/src/agent.py Outdated
Comment thread early-attack-detector-py/src/agent.py Outdated
Comment thread early-attack-detector-py/src/agent.py Outdated
@RCantu92
RCantu92 requested a review from Vxatz June 14, 2024 16:27

@Vxatz Vxatz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread early-attack-detector-py/src/findings.py Outdated
Comment thread early-attack-detector-py/src/utils.py Outdated
Comment thread early-attack-detector-py/src/agent.py Outdated
@Vxatz
Vxatz self-requested a review August 22, 2024 21:19

@Vxatz Vxatz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants