fix 'brazil +55' length size to account for 2 digits area code eg. 41999047777#11
Open
erickib wants to merge 1 commit intofonibo:mainfrom
Open
fix 'brazil +55' length size to account for 2 digits area code eg. 41999047777#11erickib wants to merge 1 commit intofonibo:mainfrom
erickib wants to merge 1 commit intofonibo:mainfrom
Conversation
Member
|
Could you please provide a sample phone number (not an actual one, just want to confirm if the implementation is alright). |
Author
|
Yes, sure. For landlines the size is 8, eg. 1234-5678. |
Member
|
So excluding the country code (+55), can we say that the number (including area, operator, etc..) length will be either 10 or 11. In that case we'll need |
Author
|
Yes you are right. Let me know if you need another PR to fix that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ability to include area code + phone number.