Conversation
On Windows, hererocks installs `bin/luarocks.bat`. The build already spawns it with the `.bat` extension, but the health check spawned `bin/luarocks`, which `vim.fn.executable()` accepts (PATHEXT) but the process can't be spawned without the extension. So a working hererocks install was reported as "failed to get version of ..." and "... not installed". Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Windows, hererocks installs
lazy-rocks/hererocks/bin/luarocks.bat.M.build()already spawns it with the.batextension (rockspec.lua,if Util.is_win then luarocks = luarocks .. ".bat" end), but the health check (M.check()) passesM.hererocks.bin("luarocks")without it.vim.fn.executable()accepts the extensionless path (PATHEXT), but spawning it fails, so:checkhealth lazyreports a working install as broken:This uses
luarocks.baton Windows in the health check too.Tested on Windows 10 with Neovim 0.12.5 and a hererocks install (Lua 5.1.5, LuaRocks 3.8.0):
require("lazy.manage.process").exec({ ".../bin/luarocks", "--version" })fails to spawn; with.../bin/luarocks.batit returns exit code 0 and LuaRocks' version;:checkhealth lazybefore: 2 errors and the warning above; after:✅ OK {.../bin/luarocks.bat} ... 3.8.0and no luarocks errors or warnings.Related Issue(s)
None that I found.
🤖 Generated with Claude Code