Add TypeScript typings generation from JSDocs; Updated some docs#293
Draft
AgainPsychoX wants to merge 1 commit intofoliojs:masterfrom
Draft
Add TypeScript typings generation from JSDocs; Updated some docs#293AgainPsychoX wants to merge 1 commit intofoliojs:masterfrom
AgainPsychoX wants to merge 1 commit intofoliojs:masterfrom
Conversation
|
Working with fontkit in Typescript has been very tricky. Curious if there's anyone looking to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be hard to port project to TypeScript and maintaining typings at DefinitelyTyped is annoying (current ones are outdated too), but fortunately we can use JSDocs! 😃
After accepting and merging the pull request, please follow https://github.com/DefinitelyTyped/DefinitelyTyped#removing-a-package to remove old typings from there.
While it works for me, I can see the even JSDocs included in this library JS code are lacking, so I will try my best to work on those a bit.
[This is draft,
more commits comingI hope I get soon more free time to work on this :/ ]