Skip to content

(Buggy in note)Edit Lane title on click title #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
flyjwayur wants to merge 1 commit into
base: master
Choose a base branch
from
Open

(Buggy in note)Edit Lane title on click title #6

flyjwayur wants to merge 1 commit into from

Conversation

@flyjwayur
Copy link
Owner

@flyjwayur flyjwayur commented Mar 11, 2019

  1. Destructuring lane properties where the lane is provided by reducer in lanes' component and to make code more readable, change to handle a editable flag with React hook from Redux and keep a same prop name as an action name,
  2. Need to fix note edit when there are several notes. (Solution: giving id to edit, so either design data with redux/hook)

@flyjwayur
(Buggy in note)Edit Lane title on click title
e4a26a2 
1) Destructuring lane properties where the lane is provided by reducer in lanes' component and to make code more readable, change to handle a editable flag with React hook from Redux and keep a same prop name as an action name, 2) Need to fix note edit when there are several notes. (Solution: giving id to edit, so either design data with redux/hook)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@flyjwayur