feat(signature): add optional CMS and timestamp renderer - #215
Merged
wybaby168 merged 6 commits intoAug 27, 2026
Conversation
Member
|
Thank you for cloning the repository, building the proof of concept, and contributing a useful synthetic fixture corpus—this is substantial work. We are validating it against the full release matrix; before merge, we will keep the signature renderer as an optional package (not included by default in full) and add it to the support matrix. |
wybaby168
marked this pull request as ready for review
August 27, 2026 10:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@file-viewer/renderer-signaturefoundation for local CMS/PKCS#7, CAdES-adjacent, RFC 3161, RFC 5544, and public OpenPGP inspection.preset-all, any of the eight*-fullpackages, core, or the standard renderer build.Related issue
Related to #206. This PR lands the verified first-phase contribution; it does not by itself close the broader ASiC, evidence-record, PAdES, XAdES, JWS/JAdES, and signed-email roadmap in that issue.
Change classification
Verification
pnpm --filter @file-viewer/renderer-signature verifycargo check --locked --target wasm32-unknown-unknownCargo.lockpnpm --filter '@file-viewer/preset-all...' buildpnpm build:componentspnpm verify:github-governancegit diff --checkThe browser gate uses Playwright 1.61.1 in Chromium, Firefox, and WebKit. It renders the contributed encapsulated CMS fixture under CSP and Trusted Types, verifies the signature and content digest, rejects external requests, checks unsafe event attributes, and confirms cleanup after unmount.
Sample / fixture evidence
Repository fixture: encapsulated CMS fixture
packages/renderers/signature/test/fixtures/github-206-contributed/packages/renderers/signature/test/fixtures/github-206-contributed/cms/packages/renderers/signature/test/fixtures/github-206-contributed/timestamps/packages/renderers/signature/test/fixtures/github-206-contributed/negative/packages/renderers/signature/test/fixtures/github-206-contributed/originals/The corpus is synthetic and non-secret. Its root CA is intentionally untrusted, no private key is included, and all 42 committed files are checked against
SHA256SUMSbefore semantic verification.Visual evidence
Before: N/A — this is a new optional renderer with no previous UI.
After, rendered directly from this PR head and the contributed CMS fixture:
Risk and compatibility
@file-viewer/renderer-signaturepackage, its offline verification assets, and CMS/PKCS#7, RFC 3161, RFC 5544, and OpenPGP documentation entries.preset-allor any*-fullpackage, so existing install size and default behavior are unchanged.*-fullpackages andpreset-all.Checklist