feat: add typed Python SDK - #18
Merged
Merged
Conversation
fly1d
commented
Aug 12, 2026
fly1d
left a comment
Owner
Author
There was a problem hiding this comment.
Final technical review completed after all required CI checks passed.
Findings resolved before submission:
- Python 3.12 generic syntax was replaced with Python 3.11-compatible overloads and
TypeVar - all non-2xx responses, including redirects, now become stable API errors instead of response-contract errors
py.typedwas added and verified inside the built wheel so external type checkers consume SDK annotations- path parameters are URL-escaped and HTTP client ownership is explicit
- the SDK deliberately avoids write retries until server-side idempotency exists
No unresolved blocking code findings remain. The wheel was installed in a clean virtual environment, and the SDK completed a real register -> activate -> approval -> decision -> audit flow against the FastAPI service.
Merge remains pending the independent approval required for medium-risk changes by docs/QUALITY_GATES.md.
fly1d
force-pushed
the
codex/python-sdk
branch
from
August 14, 2026 10:21
786a91c to
e847c50
Compare
Owner
Author
Solo-maintainer owner decision
This decision follows the solo-maintainer policy merged in #23. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
httpx.ClienttransportsCloses #17.
Risk classification
Medium. This adds an SDK and promotes
httpxfrom a development-only dependency to a runtime dependency. It does not change server behavior, storage, or HTTP schemas.Review focus
client.pyandpy.typedfor external type checkersEvidence
make check: 37 passed, 1 PostgreSQL integration test skipped without a database; 98.02% coverageagent_control_plane/client.pyandagent_control_plane/py.typedCompatibility and rollback
httpx>=0.28,<1moves to required dependencies because the distributed SDK imports itRemaining risks