fix: use tangents for smooth stroke composition#1775
Open
Kneemund wants to merge 2 commits into
Open
Conversation
4 tasks
Kneemund
commented
May 18, 2026
| /// | ||
| /// The arc is centered at `center` and connects `start` to `end`. | ||
| /// Between the two possible sweeps, the arc whose midpoint direction best aligns with `direction` is selected. | ||
| fn append_arc_between_points( |
Collaborator
Author
There was a problem hiding this comment.
I have a feeling that we could simplify the "direction selection" somehow...
Collaborator
|
I wonder if we have a systematic pen up event with 0 pressure giving 0 width at the end here from gtk... Maybe we don't want to have this at the end of each stroke ? |
Collaborator
Author
|
Maybe... But this is a more general issue, it's just that rapid pressure changes most likely occur at the end of strokes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Debug View Examples
(The bottom image shows the degenerate case where one circle is contained in the other. It falls back to the previous behavior.)