feat: multiplicative marker blending#1730
Draft
Kneemund wants to merge 4 commits into
Draft
Conversation
976ecb0 to
15383de
Compare
15383de to
ebb01a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bildschirmaufnahme_20260407_171820.webm
TODO
The SVGs that Cairo produces when multiplicative blending is involved seem to be very weird. Simplifying them using
usvgbreaks them, making them fully blank or black in all applications.When skipping the simplification, the only applications I have that were able to correctly render them were a Chromium browser, GIMP and Inkscape (didn't work in LibreOffice, Gwenview, Firefox and Rnote). This also fixed Rnote PNG exports, so I guess
librsvgcan do it... sometimes?Any help on this would be appreciated. Below is an example SVG (without simplification). I believe that this could be a dealbreaker for this PR as it seems like a Cairo bug, and Cairo is pretty much maintenance-only.