Fix HelmChart reconciler appending login options when they do not exist#1904
Merged
matheuscscp merged 2 commits intomainfrom Oct 3, 2025
Merged
Fix HelmChart reconciler appending login options when they do not exist#1904matheuscscp merged 2 commits intomainfrom
matheuscscp merged 2 commits intomainfrom
Conversation
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
matheuscscp
added
bug
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
cappyzawa
approved these changes
Oct 3, 2025
Member
cappyzawa
left a comment
cappyzawa
left a comment
There was a problem hiding this comment.
Sorry for causing the regression 🙇
The issue was that a login attempt was being made even when no login options were provided, so the fix here is to early return if there are no options, right?
LGTM！
stefanprodan
approved these changes
Oct 3, 2025
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Tested on macOS and it works! Thanks @matheuscscp
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1902
Supersedes: #1903
This PR is restoring the code path from source-controller
v1.6.2where the TLS login option was only specified if there were login credentials also specified.@stefanprodan I prefer merging this version that is a straightforward fix restoring the code path from 1.6.2 instead of revisiting this old TLS login option code in a patch release. I propose we revisit this in Flux 2.8. Please test this fix in your MacOS 🙏