Migrate event recorder to fluxcd/pkg/runtime/events.Recorder

[adri1197]

Migrate from the local eventLogf helper to fluxcd/pkg/runtime/events.Recorder, aligning with other Flux controllers.

• Embed events.Recorder and wire it in main.go via WithManager (core/v1 Kubernetes Event backend); drop the redundant local logging.
• Emit the GitRepository as the related object so notification-controller can correlate events with their source.
• Upgrade the event payload from event/v1beta1 to event/v1.
• Add an Action type for the reconcile stages (Reconcile, ListPolicies, ConfigureSource, ApplyPolicies, CommitAndPush) and attribute each failure to its stage.
• Extend the notify test to assert both the event/v1 webhook payload and the core/v1 Kubernetes Event for every outcome.

Part-of: fluxcd/flux2#5761

[matheuscscp]

Looks like we can do this here in this controller because it does not use AnnotatedEventf right?

[adri1197]

Looks like we can do this here in this controller because it does not use AnnotatedEventf right?

Correct — this controller only uses Eventf, so the migration is a direct swap 😃.

[matheuscscp]

LGTM! 🚀

[matheuscscp]

@adri1197 CI is failing, PTAL 🙏

[adri1197]

@adri1197 CI is failing, PTAL 🙏

Unfortunately, we may have to wait till kubernetes-sigs/controller-runtime#3509 and therefore the upstream k8s MR, in order to merge fluxcd/pkg#1144, which includes github.com/fluxcd/pkg/apis/event/v1 interface.

[stefanprodan]

@adri1197 please go over all the PRs and update their description, we are not moving away from core/v1 and the PR should say it.

[matheuscscp]

LGTM! 🚀

Thanks @adri1197!

@stefanprodan main attention point is probably actionForReason(), which looks reasonable to me.