Skip to content

Remove legacy VM service version checks and fallbacks - #9144

Merged
auto-submit[bot] merged 4 commits into
flutter:mainfrom
helin24:remove-old-vm-service
Oct 8, 2026
Merged

auto-submit[bot] merged 4 commits into
flutter:mainfrom
helin24:remove-old-vm-service

Conversation

@helin24

@helin24 helin24 commented Oct 7, 2026

Copy link
Copy Markdown
Member

This PR is work in preparation for removing usages of the DAS for debugging in the Flutter plugin. There are some checks for VM service version that are no longer relevant since the version is over two years old.

To test this manually, check these debugging scenarios:

  • Stopping at a breakpoint in Flutter app, Flutter test
  • Navigating in stack frame shows the right places in code
  • Pausing on exceptions

Review the contribution guidelines below:

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • I've included the required information in the description above.
  • My up-to-date information is in the AUTHORS file.
  • [ ] I've updated CHANGELOG.md if appropriate.
Contribution guidelines:
  • See
    our contributor guide and
    the Flutter organization contributor guide
    for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Dart contributions to our repos should follow the Dart style guide and use
    dart format.
  • Java and Kotlin contributions should strive to follow Java and Kotlin best
    practices (discussion).

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies VmServiceWrapper by removing deprecated fallback logic for setting isolate pause modes and mapping breakpoints, which relied on older VM service versions. Specifically, it removes supportsSetIsolatePauseMode(), addBreakpointWithMapper(), and the VmServiceVersion class, standardizing on modern VM service APIs. The review feedback suggests refactoring the addBreakpoint method to adhere to the style guide's 30-line limit and optimizing the loop in setExceptionPauseMode by reusing a single stateless SetIsolatePauseModeConsumer instance instead of instantiating it repeatedly.

Comment thread src/io/flutter/vmService/VmServiceWrapper.java
Comment thread src/io/flutter/vmService/VmServiceWrapper.java
@helin24
helin24 marked this pull request as ready for review October 7, 2026 21:51
@helin24
helin24 requested a review from pq as a code owner October 7, 2026 21:51
@helin24
helin24 force-pushed the remove-old-vm-service branch from ec492a8 to 8f9c764 Compare October 7, 2026 21:52

@pq pq left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@helin24 helin24 added the autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green. label Oct 7, 2026
@auto-submit auto-submit Bot removed the autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green. label Oct 7, 2026
@auto-submit

auto-submit Bot commented Oct 7, 2026

Copy link
Copy Markdown

autosubmit label was removed for flutter/flutter-intellij/9144, because - The status or check suite checker (VERIFY_BOT) has failed. Please fix the issues identified (or deflake) before re-applying this label.

@helin24 helin24 added the autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green. label Oct 8, 2026
@auto-submit
auto-submit Bot merged commit de31ba6 into flutter:main Oct 8, 2026
14 checks passed
@helin24
helin24 deleted the remove-old-vm-service branch October 8, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants