Repository navigation
Setup presubmit for dart_skills_lint - #67
Merged
reidbaker merged 1 commit intoApr 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request primarily focuses on minor cleanup, including fixing typos in documentation, removing trailing whitespace, and adjusting formatting in tests. It also enables the check-absolute-paths rule in the dart_skills_lint.yaml configuration. Feedback indicates that the implementation of this new rule is currently incomplete, as it lacks the necessary CLI flag registration and logic in the entry point to be fully functional and consistent with existing rules. Additionally, there are naming inconsistencies between the rule names used in the code and those documented in the README.
jwren
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63
Blocked by #66
Linting for skills/ is done only on one machine.
dart test is run on linux/windows/mac so that the integration tests can run on each platform.
Pre-launch Checklist
///).