Skip to content

Setup presubmit for dart_skills_lint - #67

Merged
reidbaker merged 1 commit into
flutter:mainfrom
reidbaker:r-setup-presubmit-for-dart-skills-lint
Apr 7, 2026
Merged

reidbaker merged 1 commit into
flutter:mainfrom
reidbaker:r-setup-presubmit-for-dart-skills-lint

Conversation

@reidbaker

@reidbaker reidbaker commented Apr 7, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #63

Blocked by #66

Linting for skills/ is done only on one machine.
dart test is run on linux/windows/mac so that the integration tests can run on each platform.

  • Setup pre commit linting, formatting, analyzing

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@reidbaker
reidbaker requested review from johnpryan and jwren April 7, 2026 15:43

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily focuses on minor cleanup, including fixing typos in documentation, removing trailing whitespace, and adjusting formatting in tests. It also enables the check-absolute-paths rule in the dart_skills_lint.yaml configuration. Feedback indicates that the implementation of this new rule is currently incomplete, as it lacks the necessary CLI flag registration and logic in the entry point to be fully functional and consistent with existing rules. Additionally, there are naming inconsistencies between the rule names used in the code and those documented in the README.

Comment thread tool/dart_skills_lint/dart_skills_lint.yaml
@reidbaker
reidbaker merged commit 7f43415 into flutter:main Apr 7, 2026
7 checks passed
@reidbaker
reidbaker deleted the r-setup-presubmit-for-dart-skills-lint branch April 7, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enforce dart-skills-lint as part of ci in flutter/skills

2 participants