Skip to content

Update skills for better contibuting documentation - #104

Merged
reidbaker merged 6 commits into
flutter:mainfrom
reidbaker:r-dart-code-support-2026-05-01
May 1, 2026
Merged

reidbaker merged 6 commits into
flutter:mainfrom
reidbaker:r-dart-code-support-2026-05-01

Conversation

@reidbaker

Copy link
Copy Markdown
Contributor
  • Check in updates to dart-test-coverage
  • Add definition of done rule and update new SkillRule command to handle interactions with on disk commands

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dart_skills_lint tool with new documentation for rule creation, a "Definition of Done" skill, and a refactored coverage interpretation script with accompanying tests. It also updates skills-lock.json to include skill paths. A recurring typo was found in skills-lock.json where the directory .agents was incorrectly referred to as .agent in several skillPath entries.

"dart-best-practices": {
"source": "kevmoo/dash_skills",
"sourceType": "github",
"skillPath": ".agent/skills/dart-best-practices/SKILL.md",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The path uses .agent (singular), but the directory structure in the repository uses .agents (plural). This typo is repeated throughout the file (lines 13, 19, 25, 31, 37, 43, 49, 55, 61) and should be corrected to ensure the tool can correctly resolve the skill paths.

Suggested change
"skillPath": ".agent/skills/dart-best-practices/SKILL.md",
"skillPath": ".agents/skills/dart-best-practices/SKILL.md",

@reidbaker
reidbaker merged commit b7cb63a into flutter:main May 1, 2026
7 checks passed
@reidbaker
reidbaker deleted the r-dart-code-support-2026-05-01 branch May 1, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant