Skip to content

These changes make the shaders to also be valid nimony - #219

Merged
floooh merged 3 commits into
floooh:masterfrom
leiserfg:don-t-use-snake-case-for-baset/wrwskxnozylv
Aug 9, 2026
Merged

floooh merged 3 commits into
floooh:masterfrom
leiserfg:don-t-use-snake-case-for-baset/wrwskxnozylv

Conversation

@leiserfg

@leiserfg leiserfg commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@leiserfg

leiserfg commented Aug 9, 2026 •

Copy link
Copy Markdown
Contributor Author

With this and the other PR I just made to the codegen, I made one of the examples to build with nimony, it needed some more changes (in the example) as now nimony is more picky than nim2 (it's semantically closer to rust I'll say). The good part is that it keeps building with nim2, so even if the user does not migrate, the code of the example will be more idiomatic.
I plan to make a pr for that (and the other examples) once these PRs get merged.

@floooh floooh left a comment •

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a change in the yaml-generator which looks unintentional (most likely a search-and-replace artifact)

Comment thread src/shdc/generators/yaml.cc Outdated
@leiserfg
leiserfg force-pushed the don-t-use-snake-case-for-baset/wrwskxnozylv branch from 554be6f to 8e67e60 Compare August 9, 2026 13:08
@floooh

floooh commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Ok thanks, I'll wait until the CI goes green and then merge (and after that kick off a new binary build pipeline).

@floooh

floooh commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Btw what's up with those weird branch names? E.g. there's always something like /wrwskxnozylv at the end?

@leiserfg

leiserfg commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Btw what's up with those weird branch names? E.g. there's always something like /wrwskxnozylv at the end?

I use jj and it marks the bookmarks with a revision id.

@floooh
floooh merged commit 0c591c3 into floooh:master Aug 9, 2026
4 checks passed
@floooh

floooh commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Eh, ok, I didn't wait for the Windows build to finish, that would take ages...

...and merged. Thanks!

Once this CI pipeline goes green, the binaries in https://github.com/floooh/sokol-tools-bin will be uptodate:

https://github.com/floooh/sokol-tools/actions/runs/31317096224

@floooh

floooh commented Aug 9, 2026 •

Copy link
Copy Markdown
Owner

(I currently run a lot of other CI pipelines because of a big-ish sokol-gfx merge, so that may take a while, the Mac runners seem to be a bit 'over-subscribed' atm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants