FlowSystem methods removed: #553
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- sel() → use transform.sel() - isel() → use transform.isel() - resample() → use transform.resample() - plot_network() → use topology.plot() - start_network_app() → use topology.start_app() - stop_network_app() → use topology.stop_app() - network_infos() → use topology.infos() - _dataset_sel(), _dataset_isel(), _dataset_resample(), _resample_by_dimension_groups() → use TransformAccessor class methods Parameters removed: - normalize_weights from create_model(), build_model(), optimize() Files updated: - flixopt/flow_system.py - removed deprecated methods - flixopt/optimize_accessor.py - removed normalize_weights parameter - flixopt/optimization.py - removed normalize_weights from Optimization classes - tests/test_*.py - updated to use new APIs - CHANGELOG.md - documented removals Still deprecated (for v7.0.0): - Optimization, SegmentedOptimization, Results, SegmentedResults classes - these are kept as they don't affect loading old solutions/flow_systems
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- tests/deprecated/test_flow_system_resample.py - tests/deprecated/test_resample_equivalence.py - tests/deprecated/examples/ folder Fixed files: - flixopt/optimization.py - SegmentedOptimization now uses transform.sel() - tests/deprecated/test_scenarios.py - updated to use transform.sel() - tests/deprecated/test_network_app.py - updated to use topology.start_app()/stop_app() - tests/deprecated/test_results_io.py - updated to use topology.plot()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameters removed:
Files updated:
Still deprecated (for v7.0.0):
Description
Brief description of the changes in this PR.
Type of Change
Related Issues
Closes #(issue number)
Testing
Checklist