Repository navigation
fix(deps): bump tinypool to >=2.1.2 (CVE-2026-104849) - #826
Conversation
Add tinypool >=2.1.2 to npm overrides to resolve CVE-2026-104849, a critical prototype pollution vulnerability in tinypool < 2.1.2. The override bumps the transitive dependency (via vitest) from 1.1.1 to 2.2.0.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review. WalkthroughThe root ChangesDependency Override
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested labels: Suggested reviewers: Merge Risk: ⚪ Minimal · up to The override targets a patched Tinypool version, with no verified compatibility blocker. It is mergeable after normal dependency checks. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (14 passed)
Full details: No-Hardcoded-SecretsExplanation The pull request adds a 88-character Base64 string to Resolution Remove the newly added long Base64 literal from the changed configuration, or store it through an approved non-literal mechanism. If npm integrity metadata must remain in
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
Fixes CVE-2026-104849, a critical (CVSS 9.5) prototype-pollution vulnerability in
tinypoolversions prior to 2.1.2.Details
tinypool1.1.1 was locked inpackage-lock.jsonas a transitive dependency ofvitest. The vulnerability allows code injection through prototype pollution ofObject.prototype.filename, which can trick the worker pool into loading attacker-controlled JavaScript.This change adds
"tinypool": ">=2.1.2"to the existingoverridessection in the rootpackage.json, forcing npm to resolve tinypool version 2.2.0. Onlypackage.jsonandpackage-lock.jsonare modified.Validation
npm ls tinypoolconfirms version 2.2.0 (overridden)AI-generated. Review for accuracy.
@celdrake requested from Slack
Summary
The change adds a root
package.jsonoverride that requirestinypool>=2.1.2. The lockfile resolves the package to2.2.0. This overrides the version requested byvitest(^1.1.1).The change is limited to dependency configuration. It does not change files in
libs/ui-components/,libs/types/,libs/i18n/,libs/cypress/,apps/standalone/,apps/ocp-plugin/,proxy/,packaging/, or.github/workflows/. It does not affect shared UI components, platform-specific app code, the Go auth proxy, container builds, E2E tests, or CI configuration. No cross-cutting product-code impact is evident.The stated security objective is to require a
tinypoolversion at or above the specified threshold. The supplied evidence does not include an independent vulnerability assessment, test results, or review findings.Risk classification
The applied risk label and its classification criteria are unavailable in the supplied evidence. The labeling instructions were not provided, so this summary cannot determine whether
risk:ship,risk:show, orrisk:askwas applied, or whether another classification was close.