Add flashblock timing configuration options #348
+109
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
requested review from
0x416e746f6e,
SozinM and
karim-agha
as code owners
- Add --flashblocks.build-at-interval-end flag to wait for interval before building first flashblock instead of building immediately - Add --flashblocks.send-offset-ms to adjust flashblock send timing (positive = send later, negative = send earlier) - Refactor payload loop to wait for signal before building flashblocks - Fix log message in tx_manager (funding -> registering) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
avalonche
force-pushed
the
flashblock-timing-config
branch
from
d2ed7f7 to
e5f651b
Compare
Collaborator
|
Why is index 5 flashblock in the middle? |
Contributor
This is because the leeway time is applied to the last flashblock. Here it's set to 100ms so fb 5 comes 100ms earlier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
💡 Motivation and Context
Make flashblocks timing closer to every 200 ms
Sampling local timing
✅ I have completed the following steps:
make lintmake test