Skip to content

Don't surface implicitly run connector-level models in Quickstart#182

Merged
fivetran-jamie merged 3 commits into
mainfrom
fix/clean-public-models
Jul 13, 2026
Merged

Don't surface implicitly run connector-level models in Quickstart#182
fivetran-jamie merged 3 commits into
mainfrom
fix/clean-public-models

Conversation

@fivetran-jamie

Copy link
Copy Markdown
Contributor

PR Overview

Package version introduced in this PR:

  • 2.7.2

This PR addresses the following Issue/Feature(s):

Summary of changes:

  • For individual sources, only surfaces public_models that are not referenced by Ad Reporting models at all. This includes 2 Google Ads models and 1 Amazon Ads report.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-jamie fivetran-jamie self-assigned this Jul 10, 2026
@fivetran-jamie
fivetran-jamie marked this pull request as ready for review July 10, 2026 18:27
@fivetran-jamie fivetran-jamie added the docs:ready Triggers the docs generator workflow. label Jul 10, 2026

@fivetran-catfritz fivetran-catfritz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fivetran-jamie
fivetran-jamie merged commit c51b834 into main Jul 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants